The Daily WTF: Curious Perversions in Information Technology
Welcome to TDWTF Forums Sign in | Join | Help
in Search

We don't do code reviews..

Last post 05-17-2012 6:57 AM by oheso. 67 replies.
Page 1 of 2 (68 items) 1 2 Next >
Sort Posts: Previous Next
  • 05-10-2012 6:13 AM

    We don't do code reviews..

    "We don't do code reviews" said my new boss when I started. "We've got developers of very mixed abilities here and I don't want the juniors to feel bad about their work. I don't particularly mind how people do their work as long as it gets done and the quality is good".

    Not doing code reviews is precisely how quality shite like this makes it into production:

    Last line of a 150-line ASP.net Page_Load handler: this.PreRender += new EventHandler(Detail_PreRender);

    Can somebody tell me why?

    Exception handling is as follows:

    catch (Exception exp)
    {
        exp.ToString();
    }

    Nice.

    In the same page there is a 200-line method that builds the UI. No, the UI isn't in the markup but first implemented as an xml file that bears a passing resemblence to html. This xml file is then transformed with an xslt and the method loops over the resultant transformed xml, dynamically creating controls and adding them to the page. Nobody customises the original xml file so you can't even argue that it's actually dynamic.

    Code reviews, coming to all junior developers near me, every day until you can be trusted. Which will be never. 

  • 05-10-2012 6:35 AM In reply to

    • TheRider
    • Top 200 Contributor
    • Joined on 03-01-2005
    • Zurich, Switzerland
    • Posts 351

    Re: We don't do code reviews..

    JimLahey:

    "We don't do code reviews" said my new boss when I started. "We've got developers of very mixed abilities here and I don't want the juniors to feel bad about their work. I don't particularly mind how people do their work as long as it gets done and the quality is good".

    The "and the quality is good" is the key here. Without code reviews, nobody knows what the quality actually is. If he really wants quality, he needs to do code reviews to find out. If he doesn't want the juniors to feel bad about their work, then just do the code reviews all alone in your little room -- and maybe create a quality statistics to show your boss where the quality standards are (not).

     

    CodeNinja

    I'm starting to think our management is really a bunch of cats and someone standing nearby has a freaking laser pointer.
  • 05-10-2012 6:50 AM In reply to

    Re: We don't do code reviews..

    I'm so glad that at least one other person on the planet agrees with me.

    I think he was implying that quality can be deduced from the products being released on time and passing through QA.Granted, it's one metric but QA should start with the developers and quality should also include things like readability, maintanability and adhering to some sort of common standard. It's ASP.net, not WTF.net.

  • 05-10-2012 7:10 AM In reply to

    Re: We don't do code reviews..

    JimLahey:
    I don't want the juniors to feel bad about their work
     

    TOUGH COOKIES, BUDDY.


    In complex analysis, a meromorphic function on an open subset D of the complex plane is a function that is holomorphic on all D except a set of isolated points

  • 05-10-2012 7:33 AM In reply to

    Re: We don't do code reviews..

    dhromed:
    JimLahey:
    I don't want the juniors to feel bad about their work
    TOUGH COOKIES, BUDDY.

    Indeed. But it's often more important to make the seniors feel bad about their work, since they're often more difficult to correct, and the juniors are liable to follow the example of the mistakes thinking that they're doing the right thing. And we all need correction at times.

    We don't have formal code reviews. There are some developers whose code I never trust, although sometimes I'm just too scared to look closely. Others I peek in on only occasionally .

    I denounce myself for this post
  • 05-10-2012 7:42 AM In reply to

    Re: We don't do code reviews..

    JimLahey:
    It's ASP.net, not WTF.net.
    Ahem. So different indeed.

    Ionian peculiar of Pervertiti in the technology of the process of the data
  • 05-10-2012 7:47 AM In reply to

    • locallunatic
    • Top 50 Contributor
    • Joined on 05-19-2010
    • (YourLocation==USA-KY?local:MisleadingUsername)
    • Posts 838

    Re: We don't do code reviews..

    dhromed:
    JimLahey:
    I don't want the juniors to feel bad about their work
    TOUGH COOKIES, BUDDY.
    I'm more curious about how a code review is supposed to make a junior feel bad. I mean "Hey you could use this thingy here instead and it would make your life easier" makes people feel bad? How?
  • 05-10-2012 7:50 AM In reply to

    Re: We don't do code reviews..

    Nice one. :)

  • 05-10-2012 7:55 AM In reply to

    Re: We don't do code reviews..

    locallunatic:
    I'm more curious about how a code review is supposed to make a junior feel bad. I mean "Hey you could use this thingy here instead and it would make your life easier" makes people feel bad? How?
    You're obviously not up on the state of the art in self esteem creation and maintenance. Please do not disturb the precious snowflakes.
    I denounce myself for this post
  • 05-10-2012 7:57 AM In reply to

    Re: We don't do code reviews..

    Me and the development manager just had an extended chat about it and he knows of several developers here who don't react well to criticism and are pretty stuck in their ways. He also supports my suggestion that a designated person on each product team should assume the role of reviewer so I'm good to go on my plan. Now I'm code reviewer, scrum master and the only guy who's ever heard of sketching something out in Visio before I start work on a product feature that will be in production for a number of years. How does the saying go again, speak softly but carry a big stick? Does it matter that the stick is a junior's arm that I've just torn off?

  • 05-10-2012 8:06 AM In reply to

    Re: We don't do code reviews..

    JimLahey:
    How does the saying go again, speak softly but carry a big stick?
    This reminded me of an instant classic from Sheriff Joe
    I denounce myself for this post
  • 05-10-2012 12:40 PM In reply to

    Re: We don't do code reviews..

    I think I've just reached the very zenith of WFTery today. I challenge anyone to produce something quite so pointless, obsolete, retarded and awful as this:

    string pagging = string.Empty;
    double pages = jobAmount / double.Parse(ViewState["pageSize"].ToString());
    bool setBeginTag = true, setEndTag = true;
    const int amountOfLinksVisible = 15;
    int currentPage = int.Parse(ViewState["pageIndex"].ToString());

    for (int i = currentPage - (amountOfLinksVisible / 2); i < (currentPage + (amountOfLinksVisible / 2)) + pages - ((int)pages); i++)
    {
        if (i < 0) setBeginTag = false;
        else if (i >= pages)
        {
            setEndTag = false;
            break;
        }
        else if (i == currentPage) pagging += "<i> " + (i + 1) + " </i>";
        else pagging += "<a href=javascript__doPostBack('Pagging','" + i + "')> " + (i + 1) + " </a>";
    }
    pagging = (setBeginTag
                  ? "<a href=javascript__doPostBack('Pagging','" + 0 + "')> << </a>.."
                  : string.Empty) + pagging + (setEndTag
                        ? "..<a href=javascript__doPostBack('Pagging','" + (int)(Math.Ceiling(pages) - 1) + "')> >> </a>"
                        : string.Empty);

    // get amount of cells for colspan
    int cellAmount = cells.Count;
    cells.Clear();
    cells.Add(new TableCell { Text = "<td align=center colspan=" + cellAmount + ">" + pagging + "</td>" });

    I had wondered why no amount of styling would change the appearance of the pager on all the GridViews in our application. The original author had implemented all the paging himself in the FooterTemplate instead of using the built in functionality that has been part of the ASP.net GridView (DataGrid for all you fellow lifers out there) since ASP.net was released over a decade ago. Be aware that this code is copypasta on every page that has a paged table. The ratio of copypasta to GridViews is 1-1, so on our page with two GridViews, this code is present twice.

    I'm going back to the judge and I'm going to ask for the death penalty instead if I am going to have to put up with this for the next 30 years.

  • 05-10-2012 1:11 PM In reply to

    Re: We don't do code reviews..

    JimLahey:

    I think I've just reached the very zenith of WFTery today. I challenge anyone to produce something quite so pointless, obsolete, retarded and awful as this:

    *snip unformatted code*

    I had wondered why no amount of styling would change the appearance of the pagger on all the GridViews in our application. The original author had implemented all the pagging himself in the FooterTemplate instead of using the built in functionality that has been part of the ASP.net GridView (DataGrid for all you fellow lifers out there) since ASP.net was released over a decade ago. Be aware that this code is copypasta on every pagg that has a pagged table. The ratio of copypasta to GridViews is 1-1, so on our pagg with two GridViews, this code is present twice.

    I'm going back to the judge and I'm going to ask for the death penalty instead if I am going to have to put up with this for the next 30 years.

    FTFY
  • 05-10-2012 1:48 PM In reply to

    Re: We don't do code reviews..

    JimLahey:

    Exception handling is as follows:

    catch (Exception exp)
    {
        exp.ToString();
    }

    They wanted to get rid of that annoying "variable 'exp' is declared but never used" warning.
      <-  I couldn't make my shit work, so here's a Godzilla head.
  • 05-10-2012 2:59 PM In reply to

    Re: We don't do code reviews..

    pkmnfrk:
    JimLahey:

    I think I've just reached the very zenith of WFTery today. I challenge anyone to produce something quite so pointless, obsolete, retarded and awful as this:

    *snip unformatted code*

    I had wondered why no amount of styling would change the appearance of the pagger on all the GridViews in our application. The original author had implemented all the pagging himself in the FooterTemplate instead of using the built in functionality that has been part of the ASP.net GridView (DataGrid for all you fellow lifers out there) since ASP.net was released over a decade ago. Be aware that this code is copypasta on every pagg that has a pagged table. The ratio of copypasta to GridViews is 1-1, so on our pagg with two GridViews, this code is present twice.

    I'm going back to the judge and I'm going to ask for the death penalty instead if I am going to have to put up with this for the next 30 years.

    FTFY
    Damn straight... If you're going to be wrong, be wrong consistently!
  • 05-10-2012 3:41 PM In reply to

    Re: We don't do code reviews..

    dhromed:

    JimLahey:
    I don't want the juniors to feel bad about their work
     

    TOUGH COOKIES, BUDDY.

    Hey, I'm self-aware enough to know that I am not the smartest coder in the world.

    Therefore, there are people smarter than me, who can teach me useful things. Which, in turn, gives me more experience and makes me even smarter.

    Therefore, I welcome constructive cricitism from my peers and from other developers. More experienced developers can teach me things. Less experienced developers who ask "why did you do it that way?" give me a chance to explain myself, teach others, and everybody benefits.

    If an employee -- at ANY level, not just juniors -- doesn't want his work peer reviewed because he might "feel bad" then that is a huge red flag.

     

  • 05-10-2012 4:06 PM In reply to

    Re: We don't do code reviews..

    WhiskeyJack:
    If an employee -- at ANY level, not just juniors -- doesn't want his work peer reviewed because he might "feel bad" then that is a huge red flag.
    What if you're so much smarter than everyone else that having lesser coders review your work makes no sense, like having an ant try to comprehend the Sistine Chapel?

    Let the healing begin!

  • I may not agree with everything Morbs just said, but he expresses himself in a way that is dignified, respectful, polite and non-threatening!
  • 05-10-2012 4:11 PM In reply to

    Re: We don't do code reviews..

    morbiuswilters:
    WhiskeyJack:
    If an employee -- at ANY level, not just juniors -- doesn't want his work peer reviewed because he might "feel bad" then that is a huge red flag.
    What if you're so much smarter than everyone else that having lesser coders review your work makes no sense, like having an ant try to comprehend the Sistine Chapel?
     

     

    I have others review my code so that even if they can understand a little bit of it, they will be that much better for it. There is always something for them to learn.

  • 05-10-2012 4:15 PM In reply to

    Re: We don't do code reviews..

    JoeCool:

    morbiuswilters:
    WhiskeyJack:
    If an employee -- at ANY level, not just juniors -- doesn't want his work peer reviewed because he might "feel bad" then that is a huge red flag.
    What if you're so much smarter than everyone else that having lesser coders review your work makes no sense, like having an ant try to comprehend the Sistine Chapel?
     

    I have others review my code so that even if they can understand a little bit of it, they will be that much better for it. There is always something for them to learn.

    Agreed... Plus even the smartest people make bone headed mistakes.... Code review is a MUST.

     (...and Morb's...I am willing to bet that I can even make a claim for one of the biggest boneheaded mistakes on this forum....anyone else ever slam the main gun of a warship into the deck with sufficient force to crack the cradle?)

  • 05-10-2012 4:23 PM In reply to

    Re: We don't do code reviews..

    morbiuswilters:
    WhiskeyJack:
    If an employee -- at ANY level, not just juniors -- doesn't want his work peer reviewed because he might "feel bad" then that is a huge red flag.
    What if you're so much smarter than everyone else that having lesser coders review your work makes no sense, like having an ant try to comprehend the Sistine Chapel?
    The Senior has no Bugs! Which is better than that he have no clothes.
    I denounce myself for this post
  • 05-10-2012 4:33 PM In reply to

    Re: We don't do code reviews..

    boomzilla:
    morbiuswilters:
    WhiskeyJack:
    If an employee -- at ANY level, not just juniors -- doesn't want his work peer reviewed because he might "feel bad" then that is a huge red flag.
    What if you're so much smarter than everyone else that having lesser coders review your work makes no sense, like having an ant try to comprehend the Sistine Chapel?
    The Senior has no Bugs! Which is better than that he have no clothes.

    But when any team members have bugs crawling on their clothes, you know it is time to RUN

  • 05-10-2012 4:45 PM In reply to

    Re: We don't do code reviews..

     I once worked with a guy who got filthier as the week went by, but was clean every Monday. I'm guessing he showered every Sunday night whether he needed it or not.

  • 05-10-2012 4:46 PM In reply to

    Re: We don't do code reviews..

    TheCPUWizard:
    I am willing to bet that I can even make a claim for one of the biggest boneheaded mistakes on this forum
    There are two kinds of people in this world: sharks and sheep. Obviously, I am a shark. You just outed yourself as a sheep. A sheep who doesn't comprehend the Sistine Chapel that this shark has painted.

    TheCPUWizard:
    anyone else ever slam the main gun of a warship into the deck with sufficient force to crack the cradle?
    Yes, but it was a "Hold my beer and watch this" moment, so it doesn't count.

    Let the healing begin!

  • I may not agree with everything Morbs just said, but he expresses himself in a way that is dignified, respectful, polite and non-threatening!
  • 05-10-2012 4:54 PM In reply to

    Re: We don't do code reviews..

    JoeCool:

     I once worked with a guy who got filthier as the week went by, but was clean every Monday. I'm guessing he showered every Sunday night whether he needed it or not.

    I worked with a guy who had a progressively worse BO problem. Ironically, he was an OSX user, not a Linux user like you'd expect (although he had switched to OSX from Linux, so..) He was one of these people who insisted OSX was super-duper superior to Windows in every way and that Windows was made by retarded monkeys.

    One time he used one of our Windows testing workstations to fix a bug in his Javascript. After two days, the thing was wrecked: temp files scattered across the desktop, in no pattern, with many of the icons overlapping one another; managed to install a bunch of malware while trying to test our internal web app; hosed the Registry after editing a bunch of settings because "that's what you have to do to get Windows to even be usable". Luckily we had disk images we could recover from, but I realized then and there that some people aren't cut out for using Windows.

    I wanted to fire the guy because he kept taking down all of our production sites by pushing out "fixes" he had never tested, but management wouldn't let me. I finally took away his commit access and he had to submit patches through me, since that was the only way I could be sure they were tested.

    He quit a few months later to get his PhD in CS (already had his Masters)..

    Let the healing begin!

  • I may not agree with everything Morbs just said, but he expresses himself in a way that is dignified, respectful, polite and non-threatening!
  • 05-10-2012 5:39 PM In reply to

    Re: We don't do code reviews..

    morbiuswilters:
    TheCPUWizard:
    I am willing to bet that I can even make a claim for one of the biggest boneheaded mistakes on this forum
    There are two kinds of people in this world: sharks and sheep. Obviously, I am a shark. You just outed yourself as a sheep. A sheep who doesn't comprehend the Sistine Chapel that this shark has painted.
    You forgot about the people who are the killer whales that drown the sharks. Anyways, sheep don't really have to worry about sharks. I'd rather be a sheep. All that swimming just sounds tiresome, and I can't hold my breath for very long any more.
    I denounce myself for this post
  • 05-10-2012 5:55 PM In reply to

    Re: We don't do code reviews..

    boomzilla:
    I'd rather be a sheep. All that swimming just sounds tiresome, and I can't hold my breath for very long any more.
    Gutsy statement. You're a shark. Sharks are winners. And they don't look back because they don't have necks. Necks are for sheep. I'm proud to be the shepherd to this flock of sharks.

    Let the healing begin!

  • I may not agree with everything Morbs just said, but he expresses himself in a way that is dignified, respectful, polite and non-threatening!
  • 05-10-2012 5:58 PM In reply to

    • havokk
    • Top 500 Contributor
    • Joined on 07-25-2008
    • Christchurch, New Zealand
    • Posts 204

    Re: We don't do code reviews..

    JimLahey:
    Me and the development manager just had an extended chat about it and he knows of several developers here who don't react well to criticism and are pretty stuck in their ways.
     

    That's the red flag for me. I'd lay money (a small amount, anyway) that those developers' code is *not* quality.

    One way to deal with it is to never give them a raise. If they are not willing to change how they do their job then why should their emploery change how they renumerate them? *evil grin*

     

  • 05-10-2012 6:03 PM In reply to

    • rstinejr
    • Top 500 Contributor
    • Joined on 04-11-2012
    • in desperate straits
    • Posts 120

    Re: We don't do code reviews..

    morbiuswilters:
    TheCPUWizard:
    I am willing to bet that I can even make a claim for one of the biggest boneheaded mistakes on this forum
    There are two kinds of people in this world: sharks and sheep. Obviously, I am a shark. You just outed yourself as a sheep. A sheep who doesn't comprehend the Sistine Chapel that this shark has painted.

    TheCPUWizard:
    anyone else ever slam the main gun of a warship into the deck with sufficient force to crack the cradle?
    Yes, but it was a "Hold my beer and watch this" moment, so it doesn't count.

    Dadgum, Morbs, are you from the South too??   Well hush my puppies!

  • 05-10-2012 6:07 PM In reply to

    Re: We don't do code reviews..

    morbiuswilters:
    boomzilla:
    I'd rather be a sheep. All that swimming just sounds tiresome, and I can't hold my breath for very long any more.
    Gutsy statement. You're a shark. Sharks are winners. And they don't look back because they don't have necks. Necks are for sheep. I'm proud to be the shepherd to this flock of sharks.

    I suppose I could make this shark thing work...

    CANDYGRAM

    I denounce myself for this post
  • 05-10-2012 6:37 PM In reply to

    Re: We don't do code reviews..

    morbiuswilters:
    boomzilla:
    I'd rather be a sheep. All that swimming just sounds tiresome, and I can't hold my breath for very long any more.
    Gutsy statement. You're a shark. Sharks are winners. And they don't look back because they don't have necks. Necks are for sheep. I'm proud to be the shepherd to this flock of sharks.
    I'm in Arizona.  The sheep here live a heck of a lot longer than the sharks.

  • 05-10-2012 6:55 PM In reply to

    Re: We don't do code reviews..

    rstinejr:
    Dadgum, Morbs, are you from the South too??   Well hush my puppies!
    Southern-ish midwest. I was joking about damaging a warship but I grew up hearing "hold my beer and watch this" (or as kids "hold my cigarette and watch this").

    Let the healing begin!

  • I may not agree with everything Morbs just said, but he expresses himself in a way that is dignified, respectful, polite and non-threatening!
  • 05-10-2012 6:58 PM In reply to

    Re: We don't do code reviews..

    da Doctah:

    morbiuswilters:
    boomzilla:
    I'd rather be a sheep. All that swimming just sounds tiresome, and I can't hold my breath for very long any more.
    Gutsy statement. You're a shark. Sharks are winners. And they don't look back because they don't have necks. Necks are for sheep. I'm proud to be the shepherd to this flock of sharks.
    I'm in Arizona.  The sheep here live a heck of a lot longer than the sharks.

    The sheep/shark thing was a reference to Futurama. I can't find a video because Fox is made up of assholes who can only think in the short-term and don't realize that allowing clips of a show to stay up on Youtube might make people want to give them money.

    Let the healing begin!

  • I may not agree with everything Morbs just said, but he expresses himself in a way that is dignified, respectful, polite and non-threatening!
  • 05-10-2012 7:08 PM In reply to

    Re: We don't do code reviews..

    At my last gig, I made a modification to stored procedure. Mind you, this stored procedure was pretty messed up before I got to it and managment knew it (trwtf is we had decent managment). So anyway, the manager asked the DBA to review my changes. He came back saying the entire sproc was messed up and needed to be rewritten. I reminded him that he only needed to review my changes.

    Once again he came back with problems in the sql that I had nothing to do with. So I went back to the manager and she came with me to his desk and reminded him to ONLY REVIEW MY CHANGES.

    He came back the third time, again not reviewing the changes. Apparently he did not know how to do a diff. The manager asked me I could show him. I replied, "If I have to show him how to do a diff, why is he the one reviewing my code.

    My code went into production without further review :) 
  • 05-10-2012 7:49 PM In reply to

    Re: We don't do code reviews..

    this_code_sucks:
    My code went into production without further review :) 
    That's pretty goddamn dysfunctional. Maybe better than being pestered by the inept DBA but "my company can't even manage to do code reviews" isn't something I'd smile over.

    Let the healing begin!

  • I may not agree with everything Morbs just said, but he expresses himself in a way that is dignified, respectful, polite and non-threatening!
  • 05-10-2012 7:57 PM In reply to

    Re: We don't do code reviews..

    this_code_sucks:
    Apparently he did not know how to do a diff. The manager asked me I could show him. I replied, "If I have to show him how to do a diff, why is he the one reviewing my code.

    It does make sense to have a SQL expert review SQL code, even if he is not an expert in source control. And the guy is also right to review the whole stored procedure, and not just your changes, because it is a unit of code, it won't get partially executed in production. *You* may feel that your changes are not impacting something else, but there is a reason why *he* is the DBA.

    Your manager is guilty in this situation because that was a bad call; what he did was to oil the wheel that was making the more noise (i.e.: you) instead of thinking about the big picture.



    2,993 people like this.
  • 05-10-2012 8:01 PM In reply to

    Re: We don't do code reviews..

    morbiuswilters:
    this_code_sucks:
    My code went into production without further review :) 
    That's pretty goddamn dysfunctional. Maybe better than being pestered by the inept DBA but "my company can't even manage to do code reviews" isn't something I'd smile over.

    Not really, it actually just got reviewed by another DBA

  • 05-10-2012 8:07 PM In reply to

    Re: We don't do code reviews..

    this_code_sucks:

    morbiuswilters:
    this_code_sucks:
    My code went into production without further review :) 
    That's pretty goddamn dysfunctional. Maybe better than being pestered by the inept DBA but "my company can't even manage to do code reviews" isn't something I'd smile over.

    Not really, it actually just got reviewed by another DBA

    Either it went into production without review or it didn't. If the former, I'd say that's a problem.

    Let the healing begin!

  • I may not agree with everything Morbs just said, but he expresses himself in a way that is dignified, respectful, polite and non-threatening!
  • 05-10-2012 8:08 PM In reply to

    Re: We don't do code reviews..

    Speakerphone Dude:
    this_code_sucks:
    Apparently he did not know how to do a diff. The manager asked me I could show him. I replied, "If I have to show him how to do a diff, why is he the one reviewing my code.

    It does make sense to have a SQL expert review SQL code, even if he is not an expert in source control. And the guy is also right to review the whole stored procedure, and not just your changes, because it is a unit of code, it won't get partially executed in production. *You* may feel that your changes are not impacting something else, but there is a reason why *he* is the DBA.

    Your manager is guilty in this situation because that was a bad call; what he did was to oil the wheel that was making the more noise (i.e.: you) instead of thinking about the big picture.

    It was a very, very, very large stored procedure. The recommendation had been to rewrite it; however, we did not have time. The orginal author had quit (dramatically too) after his code came under reveiw, but by then he had added too much code to rewrite by our deadline. Even though the IT department was generally pretty good, the company as a whole was pretty messed up.The DBA had been told that a rewrite was scheduled but for now we did not have time (plus it was just a report).

    Also, my changes were just to correct some spelling mistakes in the aliases

    BTW, this dba accidently deleted my DB (for a new application under development) a few times. Luckily, I had the foresight to backup

  • 05-10-2012 8:10 PM In reply to

    Re: We don't do code reviews..

    morbiuswilters:
    this_code_sucks:

    morbiuswilters:
    this_code_sucks:
    My code went into production without further review :) 
    That's pretty goddamn dysfunctional. Maybe better than being pestered by the inept DBA but "my company can't even manage to do code reviews" isn't something I'd smile over.

    Not really, it actually just got reviewed by another DBA

    Either it went into production without review or it didn't. If the former, I'd say that's a problem.

    It got reviewed, I lied for dramatic effect in my first post

  • 05-10-2012 8:13 PM In reply to

    Re: We don't do code reviews..

    this_code_sucks:
    morbiuswilters:
    this_code_sucks:

    morbiuswilters:
    this_code_sucks:
    My code went into production without further review :) 
    That's pretty goddamn dysfunctional. Maybe better than being pestered by the inept DBA but "my company can't even manage to do code reviews" isn't something I'd smile over.

    Not really, it actually just got reviewed by another DBA

    Either it went into production without review or it didn't. If the former, I'd say that's a problem.

    It got reviewed, I lied for dramatic effect in my first post

    *gasp* Lies, on my TDWTF!? For shame!

    Let the healing begin!

  • I may not agree with everything Morbs just said, but he expresses himself in a way that is dignified, respectful, polite and non-threatening!
  • 05-10-2012 8:41 PM In reply to

    Re: We don't do code reviews..

    morbiuswilters:
    this_code_sucks:
    morbiuswilters:
    this_code_sucks:

    morbiuswilters:
    this_code_sucks:
    My code went into production without further review :) 
    That's pretty goddamn dysfunctional. Maybe better than being pestered by the inept DBA but "my company can't even manage to do code reviews" isn't something I'd smile over.

    Not really, it actually just got reviewed by another DBA

    Either it went into production without review or it didn't. If the former, I'd say that's a problem.

    It got reviewed, I lied for dramatic effect in my first post

    *gasp* Lies, on my TDWTF!? For shame!

    If I told you about the WTFs I face at my current job you would think code going into prod without review was best practice. I could make like any featured article or even snoofle's posts seem like no big deal :-/

  • 05-10-2012 10:26 PM In reply to

    Re: We don't do code reviews..

    this_code_sucks:
    If I told you about the WTFs I face at my current job you would think code going into prod without review was best practice. I could make like any featured article or even snoofle's posts seem like no big deal :-/
    But I can't trust a word out of your keyboard now. [turns away to peer out the window] Just... just go..

    Let the healing begin!

  • I may not agree with everything Morbs just said, but he expresses himself in a way that is dignified, respectful, polite and non-threatening!
  • 05-10-2012 10:37 PM In reply to

    Re: We don't do code reviews..

    Speakerphone Dude:
    It does make sense to have a SQL expert review SQL code, even if he is not an expert in source control. And the guy is also right to review the whole stored procedure, and not just your changes, because it is a unit of code, it won't get partially executed in production. *You* may feel that your changes are not impacting something else, but there is a reason why *he* is the DBA.

    I'm of the opinion that the DBA shouldn't be responsible for reviewing SQL code by default; your senior developers ought to have enough SQL expertise to write and review sprocs.  The DBA ought to be busy doing SQL Servery stuff like maintaining server health, rebuilding indexes, performing backups, and trying to get the other half of the company off of MySql already, dammit.

    Peace, unless you're a cow.
  • 05-11-2012 3:11 AM In reply to

    Re: We don't do code reviews..

    JimLahey:
    "We don't do code reviews" said my new boss when I started. "We've got developers of very mixed abilities here and I don't want the juniors to feel bad about their work. I don't particularly mind how people do their work as long as it gets done and the quality is good".
    Your boss is obviously a "people's person", who cares about the sensetivities of his people and the harmony in his team. He also should be taken out and shot, because he and his people are judged on the quality of the output.

    We have a very similar situation here, where there's never any time to do code reviews. Nominally,  I should be doing that, but you know how it is... always more work than time.

    Now the previous manager has buggered off, and some developers have either followed suit or taken on a new role, and I have had to go through some of the code to make some changes or fix bugs.

    Oh. My. Goodness.

    My new manager agrees that we need to start doing code reviews, and I've decided that I'm going to do that. After all, I've written a document with a bunch of non-functional specifications when it comes to development, such as mandatory use of the PMD tool, but this document is largely ignored.

    Put it simply, you cannot trust the code of the people you work with.

     

  • 05-11-2012 4:04 AM In reply to

    • Nagesh
    • Top 50 Contributor
    • Joined on 01-31-2011
    • Hyderabad, India
    • Posts 1,064

    Re: We don't do code reviews..

    No code review is one reason for failure of project. No testing is another.

    But # 1 reason for failure of project is client not ready to sing off on on deliveries that is previously agreed up on by him..

  • 05-11-2012 5:25 AM In reply to

    Re: We don't do code reviews..

    JimLahey:
    "...I don't want the juniors to feel bad about their work."
    JimLahey:
    Does it matter that the stick is a junior's arm that I've just torn off?
    There are other ways...
  • 05-11-2012 6:30 AM In reply to

    • PJH
    • Top 10 Contributor
    • Joined on 02-14-2007
    • Newcastle, UK
    • Posts 3,906

    Re: We don't do code reviews..

    Nagesh:
    But # 1 reason for failure of project is client not ready to sing off on on deliveries that is previously agreed up on by him..
    What if they're terrible at karaoke?
    "Because you watched 'The Very Hungry Caterpillar,' we recommend 'The Human Centipede.'"
    --
    UED - Countryside: To kill Piers Morgan
  • Parp!
  • 05-11-2012 9:25 AM In reply to

    Re: We don't do code reviews..

    Severity One:

    Put it simply, you cannot trust the code of the people you work with.



    +1

    Although, code reviews go a long way to increasing quality; there are some problems. First of all, often people doing the reviewing are now qualified to be in front of a key board. In my opinion a shity coder reviewing a mentally challeged coder doesn't go that far.

    Also, the biggest problems in code bases are not usually indvidual wtfy funtions, but rather all encompasing archetechures and design patterns that were agreed upon early in the project. For example, we all know it, we all love it, THE DOUBLE DATA ACCESS LAYER PATERN. One data access layer, one business layer with no business logic that mirrors the entities exactly. <sarcasm> Now that's how you build an xml parser :) </sarcasm>

  • 05-11-2012 11:07 AM In reply to

    Re: We don't do code reviews..

    PJH:
    Nagesh:
    But # 1 reason for failure of project is client not ready to sing off on on deliveries that is previously agreed up on by him..
    What if they're terrible at karaoke?
     

    Don't feed the troll.

  • 05-11-2012 1:11 PM In reply to

    Re: We don't do code reviews..

    JoeCool:

     I once worked with a guy who got filthier as the week went by, but was clean every Monday. I'm guessing he showered every Sunday night whether he needed it or not.

    Maybe his wife loved smell of his sweat?
Page 1 of 2 (68 items) 1 2 Next >
Powered by Community Server (Non-Commercial Edition), by Telligent Systems